Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cbuild] Add list environment command #62

Merged
merged 4 commits into from
May 11, 2023
Merged

[cbuild] Add list environment command #62

merged 4 commits into from
May 11, 2023

Conversation

soumeh01
Copy link
Collaborator

@soumeh01 soumeh01 commented May 5, 2023 •
edited
Loading

Related to Open-CMSIS-Pack/devtools#783

Extended cbuild with list environment command
for e.g

$ cbuild list environment
CMSIS_PACK_ROOT=C:/Users/Test/AppData/Local/Arm/Packs
CMSIS_COMPILER_ROOT=C:/Test/cmsis-toolbox/etc
cmake=C:/tools/bin/cmake.exe, version 3.26.0
ninja=C:/Users/Test/AppData/Local/Programs/Python/Python310/Scripts/ninja.exe, version 1.10.2

or

$ cbuild list environment
CMSIS_PACK_ROOT=C:/Users/Test/AppData/Local/Arm/Packs
CMSIS_COMPILER_ROOT=C:/Test/cmsis-toolbox/etc
cmake=<Not Found>
ninja=<Not Found>

or

$ cbuild list environment -h
Print list of environment configurations

Usage:
  cbuild list environment [flags]

Flags:
  -h, --help   help for environment

Global Flags:
  -l, --log string   Save output messages in a log file

@soumeh01 soumeh01 marked this pull request as draft May 5, 2023 14:20
@soumeh01 soumeh01 force-pushed the list_environment branch 4 times, most recently from 96b7176 to b4372f0 Compare May 9, 2023 15:17
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023 •
edited
Loading

Test Results

    4 files  ±  0    28 suites  ±0   5s ⏱️ -2s
136 tests +10  136 ✔️ +10  0 💤 ±0  0 ❌ ±0 
544 runs  +40  544 ✔️ +40  0 💤 ±0  0 ❌ ±0 

Results for commit e9d11b1. ± Comparison against base commit 75fbf9f.

♻️ This comment has been updated with latest results.

@soumeh01 soumeh01 force-pushed the list_environment branch from b4372f0 to 0a3ec50 Compare May 9, 2023 15:36
@soumeh01 soumeh01 force-pushed the list_environment branch from 0a3ec50 to d348052 Compare May 10, 2023 11:26
@soumeh01 soumeh01 marked this pull request as ready for review May 10, 2023 12:35
@soumeh01 soumeh01 requested a review from brondani May 10, 2023 12:35
@soumeh01 soumeh01 changed the title Add list environment command [cbuild] Add list environment command May 10, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 27.27% and project coverage change: -3.45 ⚠️

Comparison is base (75fbf9f) 77.68% compared to head (183db63) 74.23%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #62      +/-   ##
==========================================
- Coverage   77.68%   74.23%   -3.45%     
==========================================
  Files          12       13       +1     
  Lines        1035     1106      +71     
==========================================
+ Hits          804      821      +17     
- Misses        171      223      +52     
- Partials       60       62       +2
Impacted Files Coverage Δ
pkg/builder/csolution/builder.go 52.46% <0.00%> (-9.35%) ⬇️
pkg/utils/utils.go 82.37% <50.00%> (-0.82%) ⬇️
cmd/cbuild/commands/list/list_environment.go 75.00% <75.00%> (ø)
pkg/utils/configs.go 75.00% <75.00%> (+3.00%) ⬆️
cmd/cbuild/commands/list/list.go 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

brondani
brondani previously approved these changes May 10, 2023
View reviewed changes
@soumeh01 soumeh01 requested a review from brondani May 11, 2023 07:42
@soumeh01 soumeh01 merged commit 1ea30b2 into main May 11, 2023
@soumeh01 soumeh01 deleted the list_environment branch May 11, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brondani brondani brondani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@soumeh01 @codecov-commenter @brondani